fix: early filter for default knowledge without notes (#134)

normal-computing · Apr 23, 2024 · abfc501 · abfc501
1 parent 7903a73
commit abfc501
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/common/CustomKnowledgeBase/DefaultKnowledge.tsx b/src/common/CustomKnowledgeBase/DefaultKnowledge.tsx
@@ -16,7 +16,12 @@ import HostKnowledge from "./HostKnowledge";
 const DefaultKnowledge = () => {
   const { isOpen, onOpen, onClose } = useDisclosure();
   const defaultKnowledgeBase = fetchAllDefaultKnowledge();
-
+  // some default knowledge may not have notes, filter them out
+  const hosts = Object.keys(defaultKnowledgeBase).filter((host) =>
+    defaultKnowledgeBase[host]?.rules?.some(
+      (rule) => (rule.knowledge?.notes?.length ?? 0) > 0,
+    ),
+  );
   return (
     <>
       <Button size="sm" variant="link" colorScheme="blue" onClick={onOpen}>
@@ -33,7 +38,7 @@ const DefaultKnowledge = () => {
           <ModalHeader>Default Instructions</ModalHeader>
           <ModalCloseButton />
           <ModalBody>
-            {Object.keys(defaultKnowledgeBase).map((host) => (
+            {hosts.map((host) => (
               <Box
                 key={host}
                 w="full"

diff --git a/src/common/CustomKnowledgeBase/HostKnowledge.tsx b/src/common/CustomKnowledgeBase/HostKnowledge.tsx
@@ -41,13 +41,6 @@ const HostKnowledge = ({
   if (rules === undefined) {
     return null;
   }
-  const hasNotes = rules.some(
-    (rule) => (rule.knowledge?.notes?.length ?? 0) > 0,
-  );
-  // skip if no notes
-  if (!hasNotes) {
-    return null;
-  }
 
   const handleRemove = () => {
     const newKnowledge = { ...knowledgeBase };