-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow project_id to be optional in projection class #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small issues, looks generally good.
When you merge this in, let's prefix the squashed commit with |
4655dbb
to
306319f
Compare
src/projection.ts
Outdated
return this._project_id_promise; | ||
} | ||
|
||
this._project_id_promise = this.apiCall(endpoint, 'GET').then( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding retry logic for the API call to handle transient errors and improve robustness.
First pass at making project_id optional in projection class.
When fetching anything that requires project_id, check to see if undefined, if so, fetch it from atlas_cloud endpoint.
Needs to be timed with prod deploy of atlas_cloud that introduces this route
https://github.com/nomic-ai/atlas_cloud/pull/1812
Important
Make
project_id
optional inAtlasProjection
, adddatasetId()
to fetch it if undefined, update methods, add tests, and coordinate with prod deploy.project_id
optional inAtlasProjection
class.datasetId()
method to fetchproject_id
if undefined.project_id
in constructor.getTags()
,getTagStatus()
,updateTagMask()
, andproject()
to usedatasetId()
.project.test.js
to verifydatasetId()
fetchesproject_id
correctly.package.json
from0.11.0
to0.11.1
.This description was created by
for 1863ca2. It will automatically update as commits are pushed.