Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After adding a virtual monitor, clicking on the display item will directly close the program, whether left or right clicking. And the desktop mode is inconsistent with the active signal mode. #77

Open
wshongshujun opened this issue Dec 16, 2024 · 3 comments · May be fixed by #85

Comments

@wshongshujun
Copy link

Clicking on a display item after adding a virtual monitor will cause the program to close directly, whether using left or right clicking. But after adding two or more virtual displays, you can still use the right-click button to call up the control list normally.
In the case of only one virtual display, my custom resolution is 2256 * 1504, but the actual output resolution is 2400 * 1400. After reaching two or more virtual displays, the correct signal can be output.

@nomi-san
Copy link
Owner

Which app version are you using?
Help me reproduce this bug with your screen recording.

@vip-rolo
Copy link

I‘ve meeted the same question. I click the first virtual dispaly whose resolution is 23601640, it crashed. But nothing happened when I create another one whose resolution is 19201080 and right-click on it. The app version is 0.45.0.

@liuyd-dev
Copy link

I encountered the same issue. After investigation, here are the details:

Steps to Reproduce

  1. Add a custom resolution
  2. Add a virtual display and set it to use the custom resolution from step 1
  3. Modify the custom resolution created in step 1 by changing either width or height to a different value
  4. Exit and restart the application
  5. Add a virtual display (its resolution should match the original custom resolution from step 1)
  6. Click (left or right click) on the newly added virtual display - application crashes

Root Cause

The virtual display's resolution cannot be found in either standard or custom resolution lists. This leads to a null object reference when attempting to access its properties, resulting in a null pointer exception and application crash.

Fix

A fix has been implemented in PR #85, pending review from @nomi-san .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants