Reconfigure Collections #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been working on cleansing the Genre collection / class. It was one of the simpler API data collections, so it makes the most sense to do first. Despite the fact that it small, I've noticed a lot of things that need to be cleaned up — not only in this collection, but in all collections. It may be worth it to create a base class, and extend all other collections of of it, because they will all share a lot of functionalities. Examples: `.matches( )`, `.combine( )`, and even `constructor`. More research will be needed. Nonetheless, I feel satisfied with where the Genre class has landed, and it's a good start to what will come.
Reconfiguring the Genre
Reconfiguring Country class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, but it will reconfigure all the collections to be nice and tidy! This will make the API wrapper much easier to use, develop, and maintain.