refactor: change freq_norm from string to enum (#248) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: change freq_norm from string to enum * refactor: pre-commit hook format changes * refactor: change freq_norm from string to enum * refactor: correct import * refactor: add parameterized test cases * refactor: fix import * refactor: fix variable type * refactor: fix data sphinx error * refactor: revert the change * refactor: change initialization of freq_norm from string to enum * refactor: change initialization of freq_norm from string to enum * refactor: change initialization of freq_norm from string to enum * refactor: Fix navigation_with_keys warning. Set navigation_with_keys to False to get rid of the warning. Setting it to True has negative accessibility implications: pydata/pydata-sphinx-theme#1492 * refactor: Fix navigation_with_keys warning. Set navigation_with_keys to True * refactor: revert change * refactor: set navigation_with_keys as false to prevent sphinx validation error * refactor: style consistency with \n
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
===========================================
+ Coverage 62.33% 74.41% +12.07%
===========================================
Files 33 37 +4
Lines 3876 4971 +1095
Branches 534 798 +264
===========================================
+ Hits 2416 3699 +1283
+ Misses 1336 1128 -208
- Partials 124 144 +20
☔ View full report in Codecov by Sentry. |
mdenolle
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: change freq_norm from string to enum
refactor: pre-commit hook format changes
refactor: change freq_norm from string to enum
refactor: correct import
refactor: add parameterized test cases
refactor: fix import
refactor: fix variable type
refactor: fix data sphinx error
refactor: revert the change
refactor: change initialization of freq_norm from string to enum
refactor: change initialization of freq_norm from string to enum
refactor: change initialization of freq_norm from string to enum
refactor: Fix navigation_with_keys warning.
Set navigation_with_keys to False to get rid of the warning. Setting it to True has negative accessibility implications: pydata/pydata-sphinx-theme#1492
Set navigation_with_keys to True
refactor: revert change
refactor: set navigation_with_keys as false to prevent sphinx validation error
refactor: style consistency with \n