feat: add opcodes profile information #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs noir-lang/noir#3496 |
|
this is great, thanks @kobyhallx |
signorecello
approved these changes
Nov 23, 2023
|
I'm not seeing any line decorations in vscode. It's instead throwing an error that Edit: managed to fix this. There's not very good feedback in the case where the profiling codelens fails. |
Merged
kobyhallx
added a commit
that referenced
this pull request
Nov 24, 2023
This reverts commit 78e529a.
Are you going to bring this fix back? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Command (with codelens
Profileand key bindingshift+alt+ctrl+n pto invoke profile command in LSP and display results as line decoration at the end, eg.// 15 ACIR opcodes. More detailed information is available on hover of individual code fragment (span).Part of
feat: Expose Profile information in vscode noir-lang/noir#3501