Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address some frontend tests TODOs #7554

Merged
merged 18 commits into from
Feb 28, 2025
Merged

chore: address some frontend tests TODOs #7554

merged 18 commits into from
Feb 28, 2025

Conversation

asterite
Copy link
Collaborator

Description

Problem

Part of #7540

Summary

Addresses the TODOs that are straight-forward to solve. I left others which are a bit more complex.

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite changed the title Ab/frontend tests todos chore: address some frontend tests TODOs Feb 28, 2025
@asterite asterite marked this pull request as draft February 28, 2025 10:37
@asterite asterite marked this pull request as ready for review February 28, 2025 12:35
@asterite asterite requested a review from a team February 28, 2025 13:04
jfecher
jfecher approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfecher jfecher added this pull request to the merge queue Feb 28, 2025
Merged via the queue into master with commit 3239a4a Feb 28, 2025
102 checks passed
@jfecher jfecher deleted the ab/frontend-tests-todos branch February 28, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asterite @jfecher