chore(ssa): Do not run passes on Brillig functions post Brillig gen #7527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
approved these changes
Feb 26, 2025
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 26, 2025
fix: No longer error on INT_MIN globals (noir-lang/noir#7519) fix: correctly format trait function with multiple where clauses (noir-lang/noir#7531) chore(ssa): Do not run passes on Brillig functions post Brillig gen (noir-lang/noir#7527)
TomAFrench
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 26, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore!: bump msrv to 1.85.0 (noir-lang/noir#7530) fix: No longer error on INT_MIN globals (noir-lang/noir#7519) fix: correctly format trait function with multiple where clauses (noir-lang/noir#7531) chore(ssa): Do not run passes on Brillig functions post Brillig gen (noir-lang/noir#7527) END_COMMIT_OVERRIDE --------- Co-authored-by: guipublic <guipublic@gmail.com> Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #7157
A small chore I noticed while working on #7522, but looks like it should resolve the linked issue as well.
Post Brillig gen we have generated our final Brillig artifacts. They are not going to be altered again.
Summary*
Run constant folding and DIE only on ACIR functions post Brillig gen.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.