Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove deprecated hash functions from stdlib #7477

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Feb 20, 2025

Description

Problem*

Resolves

Summary*

As we've pushed out 1.0.0-beta.3 which marks these functions as deprecated we can now remove them from the stdlib for the next release.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 20, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Changes to Brillig bytecode sizes

Generated at commit: 328cc099a88a65f50dcacc1ed164cc500d7764de, compared to commit: 8516bbce2b5897ab29ef2f681407a335f5b7bbff

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
conditional_regression_short_circuit_inliner_max -973 ✅ -81.70%
6_inliner_zero -675 ✅ -82.52%
6_inliner_min -831 ✅ -84.45%
6_inliner_max -976 ✅ -87.22%

Full diff report 👇
Program Brillig opcodes (+/-) %
brillig_cow_regression_inliner_max 1,295 (-680) -34.43%
conditional_1_inliner_max 726 (-390) -34.95%
brillig_cow_regression_inliner_zero 1,295 (-708) -35.35%
brillig_cow_regression_inliner_min 1,383 (-849) -38.04%
conditional_1_inliner_zero 676 (-415) -38.04%
conditional_1_inliner_min 685 (-692) -50.25%
array_dynamic_blackbox_input_inliner_max 388 (-417) -51.80%
array_dynamic_nested_blackbox_input_inliner_max 343 (-493) -58.97%
array_dynamic_nested_blackbox_input_inliner_zero 343 (-517) -60.12%
array_dynamic_blackbox_input_inliner_zero 388 (-610) -61.12%
array_dynamic_blackbox_input_inliner_min 409 (-823) -66.80%
array_dynamic_nested_blackbox_input_inliner_min 353 (-806) -69.54%
regression_4449_inliner_max 208 (-512) -71.11%
ecdsa_secp256k1_inliner_max 249 (-624) -71.48%
ecdsa_secp256k1_inliner_zero 249 (-648) -72.24%
regression_4449_inliner_zero 208 (-545) -72.38%
ram_blowup_regression_inliner_max 229 (-679) -74.78%
conditional_regression_short_circuit_inliner_zero 225 (-672) -74.92%
ram_blowup_regression_inliner_zero 229 (-690) -75.08%
ram_blowup_regression_inliner_min 265 (-832) -75.84%
conditional_regression_short_circuit_inliner_min 252 (-828) -76.67%
regression_4449_inliner_min 218 (-822) -79.04%
ecdsa_secp256k1_inliner_min 249 (-941) -79.08%
conditional_regression_short_circuit_inliner_max 218 (-973) -81.70%
6_inliner_zero 143 (-675) -82.52%
6_inliner_min 153 (-831) -84.45%
6_inliner_max 143 (-976) -87.22%

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Changes to number of Brillig opcodes executed

Generated at commit: 328cc099a88a65f50dcacc1ed164cc500d7764de, compared to commit: 8516bbce2b5897ab29ef2f681407a335f5b7bbff

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
6_inliner_max -5,850 ✅ -84.82%
regression_4449_inliner_max -196,303 ✅ -97.66%
regression_4449_inliner_zero -219,475 ✅ -97.90%
regression_4449_inliner_min -259,359 ✅ -98.21%

Full diff report 👇
Program Brillig opcodes (+/-) %
brillig_cow_regression_inliner_max 217,153 (-264,743) -54.94%
ram_blowup_regression_inliner_max 320,100 (-404,702) -55.84%
conditional_1_inliner_max 2,237 (-2,839) -55.93%
conditional_1_inliner_zero 2,277 (-3,194) -58.38%
array_dynamic_blackbox_input_inliner_max 7,113 (-10,086) -58.64%
brillig_cow_regression_inliner_min 220,361 (-345,050) -61.03%
conditional_1_inliner_min 2,290 (-3,634) -61.34%
brillig_cow_regression_inliner_zero 217,153 (-344,690) -61.35%
ram_blowup_regression_inliner_min 324,483 (-527,102) -61.90%
ram_blowup_regression_inliner_zero 320,100 (-527,752) -62.25%
array_dynamic_nested_blackbox_input_inliner_max 1,470 (-2,737) -65.06%
array_dynamic_nested_blackbox_input_inliner_zero 1,470 (-2,967) -66.87%
array_dynamic_blackbox_input_inliner_zero 7,113 (-14,384) -66.91%
array_dynamic_blackbox_input_inliner_min 7,142 (-15,401) -68.32%
array_dynamic_nested_blackbox_input_inliner_min 1,484 (-3,390) -69.55%
conditional_regression_short_circuit_inliner_zero 1,126 (-3,356) -74.88%
6_inliner_zero 1,047 (-3,358) -76.23%
conditional_regression_short_circuit_inliner_min 1,165 (-3,739) -76.24%
6_inliner_min 1,061 (-3,741) -77.91%
ecdsa_secp256k1_inliner_max 1,378 (-5,209) -79.08%
ecdsa_secp256k1_inliner_zero 1,378 (-6,284) -82.02%
ecdsa_secp256k1_inliner_min 1,378 (-6,849) -83.25%
conditional_regression_short_circuit_inliner_max 1,126 (-5,848) -83.85%
6_inliner_max 1,047 (-5,850) -84.82%
regression_4449_inliner_max 4,702 (-196,303) -97.66%
regression_4449_inliner_zero 4,702 (-219,475) -97.90%
regression_4449_inliner_min 4,716 (-259,359) -98.21%

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Changes to circuit sizes

Generated at commit: 328cc099a88a65f50dcacc1ed164cc500d7764de, compared to commit: 8516bbce2b5897ab29ef2f681407a335f5b7bbff

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
6 -149 ✅ -68.04% -4,907 ✅ -69.23%
regression_4449 -8,467 ✅ -99.06% -282,657 ✅ -99.23%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
ecdsa_secp256k1 162 (-328) -66.94% 39,325 (-4,236) -9.72%
conditional_1 2,711 (-147) -5.14% 8,116 (-2,171) -21.10%
array_dynamic_nested_blackbox_input 129 (-116) -47.35% 5,170 (-2,134) -29.22%
conditional_regression_short_circuit 89 (-149) -62.61% 4,942 (-2,164) -30.45%
ram_blowup_regression 115,714 (-25,042) -17.79% 378,185 (-265,074) -41.21%
array_dynamic_blackbox_input 819 (-543) -39.87% 9,756 (-11,626) -54.37%
6 70 (-149) -68.04% 2,181 (-4,907) -69.23%
regression_4449 80 (-8,467) -99.06% 2,207 (-282,657) -99.23%

@TomAFrench TomAFrench requested a review from a team March 3, 2025 15:24
@TomAFrench TomAFrench enabled auto-merge March 3, 2025 15:31
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant