-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: convert TraitMethodNotInScope
to error
#7427
base: master
Are you sure you want to change the base?
Conversation
@kashbrti Looks like we're triggering this error in some of the noir libraries. It should just need the trait to be imported (there should be warnings being emitted for these), can you take a look at fixing these? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: 929cdbe | Previous: 757e3c4 | Ratio |
---|---|---|---|
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
66 s |
54 s |
1.22 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
@TomAFrench the issue with |
Description
Problem*
Part of #6932
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.