Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: make ResolverError::OracleMarkedAsConstrained into a full error #7426

Merged
merged 3 commits into from
Feb 19, 2025
Merged

chore!: make ResolverError::OracleMarkedAsConstrained into a full error #7426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e287b8
chore!: make `ResolverError::OracleMarkedAsConstrained` into a full e…
TomAFrench Feb 18, 2025
978f175
.
TomAFrench Feb 19, 2025
45e36b2
Merge branch 'master' into tf/constrained-oracle-error
TomAFrench Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/benchmark_projects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
define: &AZ_COMMIT 08525884d8ea2c8575017cffed863698bba97e1b
define: &AZ_COMMIT 1350f93c3e9af8f601ca67ca3e67d0127c9767b6
projects:
private-kernel-inner:
repo: AztecProtocol/aztec-packages
Expand Down
2 changes: 1 addition & 1 deletion EXTERNAL_NOIR_LIBRARIES.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
define: &AZ_COMMIT 08525884d8ea2c8575017cffed863698bba97e1b
define: &AZ_COMMIT 1350f93c3e9af8f601ca67ca3e67d0127c9767b6
libraries:
noir_check_shuffle:
repo: noir-lang/noir_check_shuffle
Expand Down
2 changes: 1 addition & 1 deletion compiler/noirc_frontend/src/hir/resolution/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ impl<'a> From<&'a ResolverError> for Diagnostic {
"Usage of the `#[foreign]` or `#[builtin]` function attributes are not allowed outside of the Noir standard library".into(),
ident.span(),
),
ResolverError::OracleMarkedAsConstrained { ident } => Diagnostic::simple_warning(
ResolverError::OracleMarkedAsConstrained { ident } => Diagnostic::simple_error(
error.to_string(),
"Oracle functions must have the `unconstrained` keyword applied".into(),
ident.span(),
Expand Down
Loading