Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(acvm_js): Improve program handling and error messages in wit… #7232

Closed
wants to merge 1 commit into from

Conversation

VolodymyrBg
Copy link
Contributor

…ness extraction

Problem

Resolves #4428

Summary

This PR improves the handling of ACIR programs in the ACVM JS bindings witness extraction functions by:
Updating documentation to correctly refer to "program" instead of "circuit"
Improving error handling for multi-circuit programs
Making error messages more descriptive and consistent
Restructuring program validation logic for better maintainability
Preparing codebase for future multi-circuit support while maintaining current functionality

Additional Context

The changes maintain compatibility with the current single-circuit limitation of the native ACVM executor while making the code more maintainable and future-proof. The error messages have been improved to be more helpful for developers.

Documentation

[x] No documentation needed.
PR Checklist
[x] I have tested the changes locally.
[x] I have formatted the changes with cargo fmt on default settings.

Copy link
Contributor

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

@TomAFrench TomAFrench closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACIR gen / ACVM: Handle non-inlined ACIR functions
2 participants