Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Push FileManager population up to nargo_cli #3844

Merged
merged 37 commits into from
Dec 19, 2023

Conversation

kevaundray
Copy link
Contributor

Description

This tries to undo some of the changes done in #3496 where cli methods were moved into the nargo library. This pushes the populating of the file manager up to the cli commands, in most places this is just after the workspace has been resolved.

A possible next step after this is to have the nargo library to no longer ask for a file manager struct, but instead it asks for a FileManager trait which the previous FileManager struct would implement.

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

This does not entirely push population of the FileManager to the cli because noirc_driver adds the stdlib content to the file manager

@kevaundray kevaundray changed the title chore: Push FileManager population up to nargo_cli chore: Push FileManager population up to nargo_cli Dec 17, 2023
@kevaundray kevaundray marked this pull request as ready for review December 17, 2023 19:37
kevaundray and others added 5 commits December 19, 2023 13:01
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the explicit workspace root rather than relying on relative paths.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevaundray kevaundray enabled auto-merge December 19, 2023 13:52
@kevaundray kevaundray added this pull request to the merge queue Dec 19, 2023
Merged via the queue into master with commit 04dc478 Dec 19, 2023
@kevaundray kevaundray deleted the kw/make-file-manager-reference branch December 19, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants