-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Push FileManager
population up to nargo_cli
#3844
Conversation
This does not entirely push population of the FileManager to the cli because noirc_driver adds the stdlib content to the file manager |
FileManager
population up to nargo_cli
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the explicit workspace root rather than relying on relative paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This tries to undo some of the changes done in #3496 where cli methods were moved into the nargo library. This pushes the populating of the file manager up to the cli commands, in most places this is just after the workspace has been resolved.
A possible next step after this is to have the nargo library to no longer ask for a file manager struct, but instead it asks for a FileManager trait which the previous FileManager struct would implement.
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.