Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tracing to program compilation + execution #3811

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR adds tracing logs to various operations so we can track what gets called and how long it takes easily.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this as its better than nothing -- I think we'll likely want to standardize around either this or using #[tracing] over the function definition

@TomAFrench
Copy link
Member Author

Yeah, there's definitely a cleaner way of doing this but this is useful for now.

@TomAFrench TomAFrench enabled auto-merge December 14, 2023 17:58
@TomAFrench TomAFrench added this pull request to the merge queue Dec 14, 2023
Merged via the queue into master with commit 8a8d8a4 Dec 14, 2023
@TomAFrench TomAFrench deleted the tf/add-tracing branch December 14, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants