Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add comments to overflow_checks #3438

Merged
merged 4 commits into from
Nov 6, 2023
Merged

chore: add comments to overflow_checks #3438

merged 4 commits into from
Nov 6, 2023

Conversation

guipublic
Copy link
Contributor

Description

Problem*

Resolves #3381

Summary*

Added some comments

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • [ X] I have tested the changes locally.
  • [X ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

vezenovm
vezenovm reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor spelling nits mostly

@guipublic guipublic added this pull request to the merge queue Nov 6, 2023
Merged via the queue into master with commit d725b8a Nov 6, 2023
@guipublic guipublic deleted the gd/issue_3381 branch November 6, 2023 18:29
TomAFrench pushed a commit that referenced this pull request Nov 14, 2023
@guipublic @TomAFrench
chore: add comments to overflow_checks (#3438)
f4500ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezenovm vezenovm vezenovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add doc comments to check_overflow and check_signed_overflow
2 participants
@guipublic @vezenovm