Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build acvm_js for integration tests in parallel #3368

Merged
merged 2 commits into from
Oct 30, 2023
Merged

chore: build acvm_js for integration tests in parallel #3368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35295ef
chore: build acvm_js for integration tests in parallel
TomAFrench Oct 30, 2023
ce162f3
chore: fix acvm_js path
TomAFrench Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 36 additions & 16 deletions .github/workflows/test-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,33 @@ jobs:
path: ./dist/*
retention-days: 3

build-acvm-js:
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4

- name: Setup Nix
uses: ./.github/actions/nix
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
nix-cache-name: ${{ vars.NIX_CACHE_NAME }}
cachix-auth-token: ${{ secrets.CACHIXAUTHTOKEN }}

- name: Build acvm-js
run: |
nix build -L .#acvm_js

- name: Dereference symlink
run: echo "UPLOAD_PATH=$(readlink -f result/acvm_js)" >> $GITHUB_ENV

- name: Upload artifact
uses: actions/upload-artifact@v3
with:
name: acvm-js
path: ${{ env.UPLOAD_PATH }}
retention-days: 3

build-wasm:
runs-on: ubuntu-latest

Expand Down Expand Up @@ -103,7 +130,7 @@ jobs:

test-solidity-verifier:
runs-on: ubuntu-latest
needs: [build-wasm, build-nargo, build-noirc]
needs: [build-acvm-js, build-wasm, build-nargo, build-noirc]
env:
CACHED_PATH: /tmp/nix-cache

Expand All @@ -117,13 +144,19 @@ jobs:
name: nargo
path: ./nargo

- name: Download wasm package artifact
- name: Download acvm_js package artifact
uses: actions/download-artifact@v3
with:
name: acvm-js
path: ./acvm-repo/acvm_js

- name: Download noir_wasm package artifact
uses: actions/download-artifact@v3
with:
name: noir_wasm
path: ./compiler/wasm

- name: Download noirc package artifact
- name: Download noirc_abi package artifact
uses: actions/download-artifact@v3
with:
name: noirc_abi_wasm
Expand All @@ -143,22 +176,9 @@ jobs:
- name: Install Playwright
uses: ./.github/actions/install-playwright

- name: Install jq
run: sudo apt-get install jq

- name: Install wasm-bindgen-cli
uses: taiki-e/install-action@v2
with:
tool: wasm-bindgen-cli@0.2.86

- name: Install wasm-opt
run: |
npm i wasm-opt -g

- name: Setup `integration-tests`
run: |
yarn workspace @noir-lang/source-resolver build
yarn workspace @noir-lang/acvm_js build
yarn workspace @noir-lang/types build
yarn workspace @noir-lang/backend_barretenberg build
yarn workspace @noir-lang/noir_js build
Expand Down