Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: defunctionalization pass for ssa refactor #1870

Merged
merged 23 commits into from
Jul 7, 2023
Merged

feat: defunctionalization pass for ssa refactor #1870

merged 23 commits into from
Jul 7, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Jul 5, 2023 •
edited
Loading

Description

Problem*

Allows using functions as values in brillig.

Summary*

Transform all literal functions used in stores, returns, as parameters into fields, and create apply functions that choose the target function by Field comparisons. More info here

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant requested a review from kevaundray July 5, 2023 22:53
@sirasistant sirasistant changed the title feat: defunctionalization pass (WIP) feat: defunctionalization pass for ssa refactor Jul 6, 2023
@sirasistant sirasistant requested a review from jfecher July 6, 2023 08:38
@sirasistant sirasistant marked this pull request as ready for review July 6, 2023 08:38
@sirasistant sirasistant enabled auto-merge July 6, 2023 10:30
jfecher
jfecher requested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not through testing this PR locally yet but here are some initial comments.

They are mostly changes to try to avoid cloning some items.

@sirasistant sirasistant requested a review from jfecher July 6, 2023 12:25
@sirasistant sirasistant disabled auto-merge July 6, 2023 12:30
@sirasistant sirasistant requested a review from jfecher July 6, 2023 14:50
@sirasistant sirasistant requested a review from jfecher July 6, 2023 15:09
@sirasistant sirasistant enabled auto-merge July 6, 2023 17:29
@sirasistant sirasistant requested a review from jfecher July 6, 2023 17:29
jfecher
jfecher approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sirasistant sirasistant added this pull request to the merge queue Jul 7, 2023
Merged via the queue into master with commit 1d5d84d Jul 7, 2023
@sirasistant sirasistant deleted the arv/defunctionalization branch July 7, 2023 09:42
@kevaundray kevaundray mentioned this pull request Jul 7, 2023
Merged
@jfecher jfecher mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirasistant @jfecher