Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssa refactor): Add basic binary operation program #1419

Merged
merged 13 commits into from
May 30, 2023
Merged

chore(ssa refactor): Add basic binary operation program #1419

merged 13 commits into from
May 30, 2023

Conversation

kevaundray
Copy link
Contributor

Description

This is the program in #1407

Problem*

Resolves

Summary*

This PR sets out to

Example

Before:

After:

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

kevaundray added 12 commits May 26, 2023 20:35
@kevaundray
make prove_and_verify method take in the experimental-ssa flag
c43d909
@kevaundray
add new test directory for experimental-ssa
0ff2349
@kevaundray
move noir_integration code into another function and parametrize it w…
a1609d5 
…ith a boolean which will allow us to still test the normal ssa when the boolean is false, but then test the experimental ssa when true with tests in a different directory.
@kevaundray
add milestone 0 program
8b1657c
@kevaundray
use underscores since x and y are unused.
ab4fa73 
It just makes the CI have less information
@kevaundray
use convert_ssa_value to either fetch the value of a previous ValueId…
0b24f82 
… or create one if its a constant.
@kevaundray
add basic program that does binary addition
2400690
@kevaundray
Add a function to check whether the return type is the unit and then …
25ae39d 
…exit early if so
@kevaundray
use public abi for public parameters
308c40c
@kevaundray
Merge branch 'master' into kw/add-m0-program
65bb737
@kevaundray
fix clippy
b4113bc
@kevaundray
Merge branch 'kw/add-m0-program' into kw/add-m1-program
69df0e7
Base automatically changed from kw/add-m0-program to master May 27, 2023 00:01
@kevaundray kevaundray marked this pull request as ready for review May 30, 2023 09:10
@kevaundray kevaundray added this pull request to the merge queue May 30, 2023
Merged via the queue into master with commit 8778a1d May 30, 2023
@kevaundray kevaundray deleted the kw/add-m1-program branch May 30, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joss-aztec joss-aztec joss-aztec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevaundray @joss-aztec