Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: implement "document symbols" #5533

Closed
asterite opened this issue Jul 17, 2024 · 0 comments · Fixed by #5532
Closed

LSP: implement "document symbols" #5533

asterite opened this issue Jul 17, 2024 · 0 comments · Fixed by #5532
Labels
enhancement New feature or request

Comments

@asterite
Copy link
Collaborator

Problem

LSP has a feature called "document symbol" where all symbols in a document are returned as a hierarchy, including their spans. Then, the current hierarchy is shown at the top of the editor, and you can jump to any symbol in the hierarchy by doing command+o (on a Mac). It would be nice if it worked the same way in Noir.

Happy Case

LSP document symbol is implemented.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@asterite asterite added the enhancement New feature or request label Jul 17, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 17, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 17, 2024
# Description

## Problem

Resolves #5533

## Summary

With this you can see where you are at any time, and jump to any symbol
in the document.



https://github.com/user-attachments/assets/74ebdb36-cd51-4afc-a33e-775156c1317b




## Additional Context

None

## Documentation

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist

- [x] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant