Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proptest strategy which derives an InputValue consistent with a given AbiType #5226

Closed
TomAFrench opened this issue Jun 11, 2024 · 0 comments · Fixed by #5216
Closed
Labels
good first issue Good for newcomers

Comments

@TomAFrench
Copy link
Member

In #5216 we added usage of a proptest strategy which generates pairs of AbiType and InputValue which are compatible with each other.

An interesting extension for this is to instead have a strategy to generate an InputValue which is compatible with an existing AbiValue. This would allow us to generate a set of plausible inputs to a Noir program given its ABI. This would then form the basis of being able to fuzz Noir test programs.

@TomAFrench TomAFrench added the good first issue Good for newcomers label Jun 11, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 11, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 13, 2024
# Description

## Problem\*

Resolves #5226

## Summary\*

This PR adds property testing to ABI encoding so that we can show that
any valid `Abi` + `InputMap` combination can be abi encoded and decoded
to return the original inputs.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant