Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic with "no entry found for key" on duplicate field in a struct #5030

Closed
spalladino opened this issue May 14, 2024 · 1 comment · Fixed by #5585
Closed

Panic with "no entry found for key" on duplicate field in a struct #5030

spalladino opened this issue May 14, 2024 · 1 comment · Fixed by #5585
Assignees
Labels
bug Something isn't working

Comments

@spalladino
Copy link
Contributor

Aim

Running tests on the public kernel circuits in the Aztec packages repository.

Expected Behavior

Tests run.

Bug

Running ../../noir/noir-repo/target/release/nargo test --package public_kernel_lib only_valid_public_data_reads_should_be_propagated (though the same happens with any test in the package) in the folder noir-projects/noir-protocol-circuits of AztecProtocol/aztec-packages#6403 yields the following:

[public_kernel_lib] Running 1 test function
The application panicked (crashed).
Message:  no entry found for key
Location: compiler/noirc_frontend/src/node_interner.rs:1067

This is a bug. We may have already fixed this in newer versions of Nargo so try searching for similar issues at https://github.com/noir-lang/noir/issues/.
If there isn't an open issue for this bug, consider opening one at https://github.com/noir-lang/noir/issues/new?labels=bug&template=bug_report.yml

To Reproduce

No response

Project Impact

Blocker

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

Compiled from source

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@spalladino spalladino added the bug Something isn't working label May 14, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 14, 2024
@spalladino spalladino changed the title Panic during nargo test with "no entry found for key" Panic with "no entry found for key" on duplicate field in a struct May 15, 2024
@spalladino
Copy link
Contributor Author

Update: tracked this to a duplicate field in a struct. Removing it fixed the issue.

AztecProtocol/aztec-packages@a2840b2

@asterite asterite self-assigned this Jul 23, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 23, 2024
# Description

## Problem

Resolves #5030

## Summary

We weren't checking for duplicate struct fields anywhere.

## Additional Context

None.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants