Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nargo tests fails in crates with no tests within a workspace #3863

Closed
sirasistant opened this issue Dec 19, 2023 · 0 comments
Closed

Nargo tests fails in crates with no tests within a workspace #3863

sirasistant opened this issue Dec 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@sirasistant
Copy link
Contributor

Aim

Having a CI step that runs nargo tests on a workspace with multiple crates

Expected Behavior

Nargo test shouldn't fail at the first crate with no tests

Bug

It exits with an error

To Reproduce

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@sirasistant sirasistant added the bug Something isn't working label Dec 19, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 19, 2023
@sirasistant sirasistant changed the title Nargo tests fails in crates with no tests Nargo tests fails in crates with no tests within a workspace Dec 19, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 19, 2023
)

# Description

Workspaces typically contain some crates with no tests (especially
binary crates that are only entry points). Running tests without
specifying a test name on a crate won't fail with this PR if that crate
has no tests.

## Problem\*

Possible approach to #3863

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants