Skip to content

Commit

Permalink
fix(unrolling): Fetch original bytecode size from the original functi…
Browse files Browse the repository at this point in the history
…on (#7253)
  • Loading branch information
vezenovm authored Jan 31, 2025
1 parent 8d39337 commit 5841122
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion compiler/noirc_evaluator/src/ssa/opt/unrolling.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ impl Ssa {
if let Some(max_incr_pct) = max_bytecode_increase_percent {
let orig_function = orig_function.expect("took snapshot to compare");
let new_size = function.num_instructions();
let orig_size = function.num_instructions();
let orig_size = orig_function.num_instructions();
if !is_new_size_ok(orig_size, new_size, max_incr_pct) {
*function = orig_function;
}
Expand Down

2 comments on commit 5841122

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 5841122 Previous: 8d39337 Ratio
noir-lang_noir_base64_ 2 s 1 s 2
noir-lang_eddsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 5841122 Previous: 8d39337 Ratio
noir-lang_noir_base64_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Please sign in to comment.