Skip to content

Commit

Permalink
chore!: make ResolverError::OracleMarkedAsConstrained into a full e…
Browse files Browse the repository at this point in the history
…rror (#7426)
  • Loading branch information
TomAFrench authored Feb 19, 2025
1 parent d0d04e8 commit 40184eb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/benchmark_projects.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
define: &AZ_COMMIT 08525884d8ea2c8575017cffed863698bba97e1b
define: &AZ_COMMIT 1350f93c3e9af8f601ca67ca3e67d0127c9767b6
projects:
private-kernel-inner:
repo: AztecProtocol/aztec-packages
Expand Down
2 changes: 1 addition & 1 deletion EXTERNAL_NOIR_LIBRARIES.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
define: &AZ_COMMIT 08525884d8ea2c8575017cffed863698bba97e1b
define: &AZ_COMMIT 1350f93c3e9af8f601ca67ca3e67d0127c9767b6
libraries:
noir_check_shuffle:
repo: noir-lang/noir_check_shuffle
Expand Down
2 changes: 1 addition & 1 deletion compiler/noirc_frontend/src/hir/resolution/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ impl<'a> From<&'a ResolverError> for Diagnostic {
"Usage of the `#[foreign]` or `#[builtin]` function attributes are not allowed outside of the Noir standard library".into(),
ident.span(),
),
ResolverError::OracleMarkedAsConstrained { ident } => Diagnostic::simple_warning(
ResolverError::OracleMarkedAsConstrained { ident } => Diagnostic::simple_error(
error.to_string(),
"Oracle functions must have the `unconstrained` keyword applied".into(),
ident.span(),
Expand Down

1 comment on commit 40184eb

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 40184eb Previous: d0d04e8 Ratio
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_reset-kernel-lib 11 s 9 s 1.22

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Please sign in to comment.