Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update barretenberg to version with mutex on pedersen generators #21

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

kevaundray
Copy link
Contributor

Updates barretenberg to the latest commit, which adds a mutex around the init function for global generators.

This should allow us to remove the test_threads=1 limitation.

@kevaundray kevaundray changed the title Update barretenberg to version with mutex on pedersen generators fix: Update barretenberg to version with mutex on pedersen generators Apr 21, 2023
@kevaundray
Copy link
Contributor Author

Will push this forward once noir-lang/noir#1114 is merged

@kevaundray kevaundray requested review from phated and TomAFrench April 21, 2023 17:36
phated
phated previously approved these changes Apr 21, 2023
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in noir tests and the noir integration tests finish in 1 minute. I'm so hyped! Now to get binary cache for the bb builds 🚀

@phated phated enabled auto-merge April 21, 2023 19:06
@phated phated added this pull request to the merge queue Apr 21, 2023
Merged via the queue into master with commit 0a0d04b Apr 21, 2023
@phated phated deleted the kw/multi-thread branch April 21, 2023 19:45
@github-actions github-actions bot mentioned this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants