-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix homebrew pathing related to libomp #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm this builds correctly on my M1 Pro as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks fine to me but I'd like more people to test building it before merging. So far it is compiling on my M1 Pro, and I cannot test on my linux machine as that is still failing from the lack of relevant header includes.
@jfecher this should only affect Mac operating systems, everything is guarded by some sort of "apple" checks |
There's an additional argument to be made that |
I am able to build locally on my intel mac from this branch. I can test changing |
So it does build when I use |
Thanks for testing and adding the intel mac patch @vezenovm 🙇 This should be ready for approvals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
When setting up noir, I was getting build failures with the native backend. This seems to be related to bad pathing on homebrew installations.
When I installed
libomp
with homebrew, I got this message:This means that libomp wasn't symlinked into the
/Users/phated/brew/lib
directory where the cmake files expected it. I've changed it to the result ofbrew --prefix libomp
which is the actual installation location.Additionally, the
build.rs
file has a hardcoded homebrew location, instead of using the brew prefix, so I fixed that.