Fix building in Linux on ARM #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2023
|
We'll want to rebase this on @ax0 Are you available to do that or should I look into it? |
* Cargo format * Clippy fixes * Update tests to match tests in aztec_backend * Add cargo config to set clang as linker when target is x86_64-unknown-linux-gnu
* Cargo format * Clippy fixes * Update tests to match tests in aztec_backend * Add cargo config to set clang as linker when target is x86_64-unknown-linux-gnu
phated
reviewed
Jan 12, 2023
phated
reviewed
Jan 12, 2023
phated
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Thank you so much for this @ax0 🎉 I've tested it on Ubuntu ARM (using Canonical multipass on Mac M1) and everything works.
We need to note that this requires clang and lld to be installed on the system to ensure it works. It seems that ubuntu doesn't install these alongside llvm by default, so I needed to run sudo apt install clang lld
phated
pushed a commit
that referenced
this pull request
Feb 9, 2023
feat(wrapper): Flake bindgen cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current build scripts for Linux on ARM so that Barretenberg builds natively using Clang, bringing it in line with the build scripts for Linux on x86_64 and Mac OS on ARM. Some additional
#includestatements were added inbarretenbergfor compatibility with more recent toolchains (cf. AztecProtocol#13). Tested on both Ubuntu 22.04 and Arch Linux on ARM.