Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

chore: Remove unused Directive::Log #500

Closed
wants to merge 3 commits into from

Conversation

Ethan-000
Copy link
Contributor

Description

Problem*

noir-lang/noir#2358 (comment)

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the serialization of Circuit. I'd like to perform all of these removals in one go to avoid the need for updating barretenberg multiple times.

@Ethan-000
Copy link
Contributor Author

Ethan-000 commented Aug 18, 2023

i tried to updated serialization in barretenberg in this pr

let me know if theres other parts of the code that need to be changed

@kevaundray kevaundray changed the base branch from master to remove-unused-opcodes August 30, 2023 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants