Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Always use a models View serializer for the response #579

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

jon-nfc
Copy link
Member

@jon-nfc jon-nfc commented Feb 11, 2025

📚 Summary

🔗 Links / References

👷 Tasks

  • Add your tasks here if required (delete)
  • Feature Release ONLY 🟥 Squash migration files 🟥
    Multiple migration files created as part of this release are to be sqauashed into a few files as possible so as to limit the number of migrations

  • 🧨 Contains breaking-change Any Breaking change(s)?

    Breaking Change must also be notated in the commit that introduces it and in Conventional Commit Format.

    • 📓 Release notes updated
  • 📘 Documentation written

    All features to be documented within the correct section(s). Administration, Development and/or User

  • 🏁 Milestone assigned

  • ⚙️ 🧪 Functional Test(s) Written

  • 🧪 Unit Test(s) Written

    ensure test coverage delta is not less than zero

  • 📄 Roadmap updated

@jon-nfc jon-nfc added the type::feature Issue Type label Feb 11, 2025
@jon-nfc jon-nfc added this to the Next Release milestone Feb 11, 2025
@jon-nfc jon-nfc self-assigned this Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

Python Scan Results (requirements.txt)

Scan Date: 2025-02-11T11:52:14.316852105Z
File: requirements.txt

Nothing Found

@jon-nfc jon-nfc force-pushed the use-view-serializer-for-response branch from 3402083 to cd40fe6 Compare February 11, 2025 10:16
jon-nfc added a commit that referenced this pull request Feb 11, 2025
@jon-nfc jon-nfc force-pushed the use-view-serializer-for-response branch from cd40fe6 to ca6254c Compare February 11, 2025 10:19
Copy link

github-actions bot commented Feb 11, 2025

Image Scan Results

Scan Date: 2025-02-11T12:00:30.119146811Z
Image: ghcr.io/nofusscomputing/centurion-erp:485adb5c3a78b9b9182456cf55287f404878d08d
OS: alpine 3.20.3

Nothing Found

@jon-nfc jon-nfc force-pushed the use-view-serializer-for-response branch from ca6254c to 97053c0 Compare February 11, 2025 10:55
Copy link
Member Author

@jon-nfc jon-nfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jon-nfc jon-nfc force-pushed the use-view-serializer-for-response branch from 97053c0 to 485adb5 Compare February 11, 2025 11:51
@jon-nfc jon-nfc merged commit 8c83f0f into feature-next-release Feb 11, 2025
56 checks passed
@jon-nfc jon-nfc deleted the use-view-serializer-for-response branch February 11, 2025 14:46
jon-nfc added a commit that referenced this pull request Feb 14, 2025
jon-nfc added a commit that referenced this pull request Feb 15, 2025
jon-nfc added a commit that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature Issue Type
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

✔ Ensure that the serializer used for the return of a CRUD operation is the view serializer.
1 participant