DRF Serializers dont call model clean

[jon-nfc]

A change was made in DRF 3.0 that removed the feature from the Serializers that calls the models clean method.

Serilaizers within Centurion still need to call a models clean method.

Details

We use the Model clean method as it was intended, to make any changes that must be done to a model prior to saving, regardless of the data ingress point.

As we move Centurion to be predominately an API application, 99% of data ingress will be via a serializer, and the lack of calling the clean method from a serializer is not an issue. However, we do have management commands and have celery tasks as data ingress points. As such a models clean method is still in play and required that it be called.

discovered models affected.

$ grep -a 'clean(' -r . | grep -a -v cache | grep -a '.py' | grep -a 'model'
./core/models/manufacturer.py:    def clean(self):
./settings/models/app_settings.py:    def clean(self):
./settings/management/commands/device_model.py:                software.clean()
./settings/management/commands/device_model.py:                software.clean()
./itam/models/device.py:    def clean(self):
./itam/models/device_models.py:    def clean(self):
./itam/models/software.py:    def clean(self):
./itam/models/software.py:    def clean(self):
$ 

Testing

Any model that has a clean method, must be tested to ensure that the clean method is called prior to saving the model.

Links

• https://github.com/encode/django-rest-framework/issues/7159
• https://github.com/encode/django-rest-framework/issues/3144
• https://github.com/encode/django-rest-framework/discussions/7850

Requirements

• Manufacturers moved to global org on creation/update
  When a global org is set and manufactures as global is true, ALL manufacturers on creation are supposed to be moved to the global organization. This is not occurring.
• Audit remaining global model options to ensure functioning
• 🧪 Test to ensure model clean is being called #445