fix(api): Ensure device groups is read only

checks for required fields !45 #160 #162
nofusscomputing · Jul 31, 2024 · 2f55024 · 2f55024
1 parent 213644a
commit 2f55024
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/app/api/serializers/itam/device.py b/app/api/serializers/itam/device.py
@@ -43,7 +43,7 @@ class DeviceSerializer(serializers.ModelSerializer):
 
     config = serializers.SerializerMethodField('get_device_config')
 
-    groups = DeviceConfigGroupsSerializer(source='configgrouphosts_set', many=True, read_only=False)
+    groups = DeviceConfigGroupsSerializer(source='configgrouphosts_set', many=True, read_only=True)
 
     def get_device_config(self, device):
 
@@ -70,11 +70,12 @@ class Meta:
         ]
 
         read_only_fields = [
+            'id',
+            'config',
+            'inventorydate',
             'created',
             'modified',
-            'inventorydate',
-            'is_global',
-            'slug',
             'groups',
+            'url',
         ]