tools: remove Report JS and format-cpp #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Report JS check is not necessary for us since we're downstream of Node.js, but they also always fail. Remove them so it's no longer checked. We follow the cpp linter, but format-cpp adds additional checks that make the code worse. Remove it and only rely on the linter. PR-URL: #85 Co-authored-by: Santiago Gimeno <santiago.gimeno@gmail.com>
663e533 to
2b043c5
Compare
trevnorris
added a commit
that referenced
this pull request
Feb 28, 2024
The Report JS check is not necessary for us since we're downstream of Node.js, but they also always fail. Remove them so it's no longer checked. We follow the cpp linter, but format-cpp adds additional checks that make the code worse. Remove it and only rely on the linter. PR-URL: #85 Co-authored-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Report JS check is not necessary for us since we're downstream of Node.js, but they also always fail. Remove them so it's no longer checked.
We follow the cpp linter, but format-cpp adds additional checks that make the code worse. Remove it and only rely on the linter.