agents: implement data handle ring buffer #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63ebaa6 to
04bf8c7
Compare
65f4cda to
2326725
Compare
38f7e00 to
fe7c616
Compare
fe7c616 to
2074ce1
Compare
trevnorris
added a commit
that referenced
this pull request
Feb 16, 2024
Add a basic `RingBuffer<T>` implementation to `nsolid_util.h` with accompanying tests. Use it for ZMQ `data` channel messages, so we're able to buffer up to `MAX_DATA_BUFFER_SIZE` messages in case of channel disconnection. Fixes problems observed while load testing the agent, where data messages were generated before the actual `data` channel connection was established and were actually dropped. PR-URL: #69 Co-authored-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
2074ce1 to
4d726b6
Compare
trevnorris
approved these changes
Feb 16, 2024
Add a basic `RingBuffer<T>` implementation to `nsolid_util.h` with accompanying tests. Use it for ZMQ `data` channel messages, so we're able to buffer up to `MAX_DATA_BUFFER_SIZE` messages in case of channel disconnection. Fixes problems observed while load testing the agent, where data messages were generated before the actual `data` channel connection was established and were actually dropped. PR-URL: #69 Co-authored-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
4d726b6 to
ebd3f8c
Compare
trevnorris
added a commit
that referenced
this pull request
Feb 28, 2024
Add a basic `RingBuffer<T>` implementation to `nsolid_util.h` with accompanying tests. Use it for ZMQ `data` channel messages, so we're able to buffer up to `MAX_DATA_BUFFER_SIZE` messages in case of channel disconnection. Fixes problems observed while load testing the agent, where data messages were generated before the actual `data` channel connection was established and were actually dropped. PR-URL: #69 Co-authored-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic
RingBuffer<T>implementation tonsolid_util.hwith accompanying tests.Use it for ZMQ
datachannel messages, so we're able to buffer up toMAX_DATA_BUFFER_SIZEmessages in case of channel disconnection. Fixes problems observed while load testing the agent, where data messages were generated before the actualdatachannel connection was established and were actually dropped.