deps: escape strings in v8::CpuProfile::Serialize #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc21515 to
4bd618c
Compare
|
@santigimeno The function |
I think this can also affect other OS's. For example: [/tmp]$ cat \\hello.js
console.log(__filename, JSON.stringify(__filename));
[/tmp]$ nsolid \\hello.js
/tmp/\hello.js "/tmp/\\hello.js" |
trevnorris
approved these changes
Jan 9, 2024
Make sure the `url` field is escaped to avoid generating invalid JSON. PR-URL: #60 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Juan José Arboleda <soyjuanarbol@gmail.com>
4bd618c to
ccc7e91
Compare
trevnorris
pushed a commit
that referenced
this pull request
Jan 9, 2024
Make sure the `url` field is escaped to avoid generating invalid JSON. PR-URL: #60 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the
urlfield is escaped to avoid generating invalid JSON.