Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agents: apply the correct config on zmq with SaaS #59

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

santigimeno
Copy link
Member

Make sure tracing config is correctly applied after the command handshake has been performed.
Also, setup correctly the blockedLoopThreshold on both cases: connection to SaaS or to a standalone Console.

@santigimeno santigimeno self-assigned this Jan 5, 2024
Copy link
Contributor

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Make sure tracing config is correctly applied after the command
handshake has been performed.
Also, setup correctly the `blockedLoopThreshold` on both cases:
connection to SaaS or to a standalone Console.

PR-URL: #59
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Juan José Arboleda <soyjuanarbol@gmail.com>
@santigimeno santigimeno force-pushed the santi/fix_config_setup_startup branch from 476c97d to 4d144d9 Compare January 8, 2024 21:21
@santigimeno santigimeno merged commit 4d144d9 into node-v20.x-nsolid-v5.x Jan 8, 2024
15 of 18 checks passed
@santigimeno santigimeno deleted the santi/fix_config_setup_startup branch January 8, 2024 21:22
trevnorris pushed a commit that referenced this pull request Jan 9, 2024
Make sure tracing config is correctly applied after the command
handshake has been performed.
Also, setup correctly the `blockedLoopThreshold` on both cases:
connection to SaaS or to a standalone Console.

PR-URL: #59
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants