nsolid: add support for start/stopTrackingHeapObjects #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
381ae15 to
6615347
Compare
santigimeno
requested changes
Dec 15, 2023
santigimeno
reviewed
Dec 15, 2023
5c84d29 to
69593d4
Compare
santigimeno
requested changes
Dec 20, 2023
69593d4 to
b085ec8
Compare
santigimeno
requested changes
Jan 15, 2024
juanarbol
commented
Jan 26, 2024
b085ec8 to
0c356de
Compare
f187b72 to
e2857cb
Compare
e2857cb to
4699e3b
Compare
4699e3b to
5a04ab9
Compare
trevnorris
reviewed
Feb 13, 2024
5a04ab9 to
0a13cf8
Compare
trevnorris
pushed a commit
that referenced
this pull request
Feb 20, 2024
This patch implements triggers for `startTrackingHeapObjects` and `stopTrackingHeapObjects` in the heap profiler. The implementation is based on what the inspector does: The `startTrackingHeapObjects` will simply activate that in the HeapProfiler and; the `stopTrackingHeapObjects` will create a heap snapshot and deactivate the `TrackingHeapObjects` in the Heap profiler. This patch also includes the `trackAllocations` option supported. PR-URL: #48 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> Co-authored-by: Santiago Gimeno <santiago.gimeno@gmail.com> Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
0a13cf8 to
db2107b
Compare
trevnorris
approved these changes
Feb 20, 2024
trevnorris
pushed a commit
that referenced
this pull request
Feb 20, 2024
This patch implements triggers for `startTrackingHeapObjects` and `stopTrackingHeapObjects` in the heap profiler. The implementation is based on what the inspector does: The `startTrackingHeapObjects` will simply activate that in the HeapProfiler and; the `stopTrackingHeapObjects` will create a heap snapshot and deactivate the `TrackingHeapObjects` in the Heap profiler. This patch also includes the `trackAllocations` option supported. PR-URL: #48 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> Co-authored-by: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
db2107b to
16dfce0
Compare
santigimeno
approved these changes
Feb 21, 2024
This patch implements triggers for `startTrackingHeapObjects` and `stopTrackingHeapObjects` in the heap profiler. The implementation is based on what the inspector does: The `startTrackingHeapObjects` will simply activate that in the HeapProfiler and; the `stopTrackingHeapObjects` will create a heap snapshot and deactivate the `TrackingHeapObjects` in the Heap profiler. This patch also includes the `trackAllocations` option supported. PR-URL: #48 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> Co-authored-by: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
16dfce0 to
f7b4b61
Compare
trevnorris
pushed a commit
that referenced
this pull request
Feb 28, 2024
This patch implements triggers for `startTrackingHeapObjects` and `stopTrackingHeapObjects` in the heap profiler. The implementation is based on what the inspector does: The `startTrackingHeapObjects` will simply activate that in the HeapProfiler and; the `stopTrackingHeapObjects` will create a heap snapshot and deactivate the `TrackingHeapObjects` in the Heap profiler. This patch also includes the `trackAllocations` option supported. PR-URL: #48 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> Co-authored-by: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements triggers for
startTrackingHeapObjectsandstopTrackingHeapObjectsin the heap profiler.The implementation is based on what the inspector does:
The
startTrackingHeapObjectswill simply activate that in the HeapProfiler and; thestopTrackingHeapObjectswill create a heap snapshot and deactivate theTrackingHeapObjectsin the Heap profiler.This patch also includes the
trackAllocationsoption supported.