Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport remaining commits to v18.x #40

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Backport remaining commits to v18.x #40

merged 4 commits into from
Dec 6, 2023

Conversation

santigimeno
Copy link
Member

No description provided.

@santigimeno
agents: fix OTLPAgent race conditions on cleanup
cbe83bf 
Move the `exit_lock_` out of the class and make it static so we can use
it even if the agent has been deleted.
Also, make sure we use the `exit_lock_` in `OTLPAgent::config_msg_cb_`.

Fixes: #29
PR-URL: #30
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
@santigimeno
agents: fix crash in StatsDAgent
fa7b078 
With some specific udp send errors, it's not possible to retrieve the
peername. Handle this case to avoid crashes.

Fixes: #31
PR-URL: #32
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
@santigimeno
agents: fix crash in HttpCurlGlobalInitializer
6ba5054 
Make sure the HttpCurlGlobalInitializer static instance is created before
the OTLPAgent so it's destroyed after the OTLPAgent in __run_exit_handlers.
This fixes an insidious crash which happened if between the
HttpCurlGlobalInitializer and OTLPAgent destruction, a config update caused
the metrics_exporter_ to be reset to a specific exporter. This caused the
HttpCurlGlobalInitializer instance destructor to be called twice thus
crashing.

Fixes: #33
PR-URL: #34
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
@santigimeno
src: NODE_RELEASE should be node
3e1c464 
So we remain compatible with Node.js.

PR-URL: #36
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
@santigimeno santigimeno marked this pull request as ready for review December 6, 2023 16:13
@trevnorris trevnorris merged commit 3e1c464 into node-v18.x-nsolid-v5.x Dec 6, 2023
33 of 36 checks passed
@trevnorris trevnorris deleted the santi/v18.x_backports branch December 6, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevnorris trevnorris trevnorris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santigimeno @trevnorris