Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add metrics support for http2 #256

Open
wants to merge 2 commits into
base: node-v22.x-nsolid-v5.x
Choose a base branch
from
Open

lib: add metrics support for http2 #256

wants to merge 2 commits into from

Conversation

santigimeno
Copy link
Member 

lib: add diagnostic channels to http2

lib: add metrics support for http2

@santigimeno santigimeno self-assigned this Jan 21, 2025
juanarbol
juanarbol approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to say, but based on the shape, this is looking good to me.

@santigimeno santigimeno force-pushed the santi/diag_http2 branch 3 times, most recently from aae15a1 to 106d9e8 Compare January 22, 2025 11:14
RafaelGSS
RafaelGSS approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/internal/http2/core.js Outdated
@@ -2323,7 +2381,7 @@ class Http2Stream extends Duplex {
const handle = this[kHandle];
const id = this[kID];

debugStream(this[kID] || 'pending', session[kType], 'destroying stream');
// debugStream(this[kID] || 'pending', session[kType], 'destroying stream');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected?

@santigimeno santigimeno force-pushed the santi/diag_http2 branch 2 times, most recently from 7cbac44 to 49d2225 Compare January 23, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees

@santigimeno santigimeno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santigimeno @juanarbol @RafaelGSS