agents: fix grpc insecure opt initialization #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`OtlpGrpcClientOptions.use_ssl_credentials` is not initialized by default to `false` as it happens with all their children. Make sure it is otherwise it can produce undesired behaviour.
RafaelGSS
approved these changes
Jan 9, 2025
santigimeno
added a commit
that referenced
this pull request
Jan 9, 2025
`OtlpGrpcClientOptions.use_ssl_credentials` is not initialized by default to `false` as it happens with all their children. Make sure it is otherwise it can produce undesired behaviour. PR-URL: #247 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
|
Landed in c82802a |
santigimeno
added a commit
that referenced
this pull request
Jan 9, 2025
`OtlpGrpcClientOptions.use_ssl_credentials` is not initialized by default to `false` as it happens with all their children. Make sure it is otherwise it can produce undesired behaviour. PR-URL: #247 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno
added a commit
that referenced
this pull request
Jan 9, 2025
`OtlpGrpcClientOptions.use_ssl_credentials` is not initialized by default to `false` as it happens with all their children. Make sure it is otherwise it can produce undesired behaviour. PR-URL: #247 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OtlpGrpcClientOptions.use_ssl_credentialsis not initialized by default tofalseas it happens with all their children. Make sure it is otherwise it can produce undesired behaviour.