Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update opentelemetry-cpp to 1.17.0 #221

Closed
wants to merge 3 commits into from
Closed

deps: update opentelemetry-cpp to 1.17.0 #221

wants to merge 3 commits into from

Conversation

santigimeno
Copy link
Member

Float the following patch:

deps: add support for exporting Summary via OTLP
    
PR-URL: https://github.com/nodesource/nsolid/pull/180
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

@santigimeno santigimeno self-assigned this Nov 14, 2024
@santigimeno santigimeno force-pushed the santi/update-opentelemetry branch 3 times, most recently from 701b9de to c800009 Compare November 21, 2024 14:02
@santigimeno santigimeno force-pushed the santi/update-opentelemetry branch from c800009 to c89ff14 Compare November 25, 2024 09:56
juanarbol
juanarbol approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@santigimeno santigimeno force-pushed the santi/update-opentelemetry branch from c89ff14 to 1f93eda Compare December 10, 2024 15:51
@santigimeno santigimeno changed the base branch from node-v20.x-nsolid-v5.x to node-v22.x-nsolid-v5.x December 10, 2024 15:51
@santigimeno santigimeno force-pushed the santi/update-opentelemetry branch from 1f93eda to ce48ccd Compare December 10, 2024 15:52
@santigimeno
deps: update opentelemetry-cpp to 1.17.0
55747c4 
Also, a couple of fixes in the updater:
- Fix OPENTELEMETRY_VERSION extraction.
- Use `third_party_release` file to get the `opentelemetry-proto`.
@santigimeno
deps: add support for exporting Summary via OTLP
7c9876d 
PR-URL: #180
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
@santigimeno
test: get opentelemetry version from process
2f935c8
@santigimeno santigimeno force-pushed the santi/update-opentelemetry branch from ce48ccd to 2f935c8 Compare December 10, 2024 15:58
santigimeno added a commit that referenced this pull request Dec 16, 2024
@santigimeno
deps: update opentelemetry-cpp to 1.17.0
f47334b 
Also, a couple of fixes in the updater:
- Fix OPENTELEMETRY_VERSION extraction.
- Use `third_party_release` file to get the `opentelemetry-proto`.

PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno added a commit that referenced this pull request Dec 16, 2024
@santigimeno
deps: add support for exporting Summary via OTLP
d4047ed 
PR-URL: #180
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno added a commit that referenced this pull request Dec 16, 2024
@santigimeno
test: get opentelemetry version from process
5eae00f 
PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@santigimeno
Copy link
Member Author

Landed in f8697d4...5eae00f

@santigimeno santigimeno deleted the santi/update-opentelemetry branch December 16, 2024 10:37
santigimeno added a commit that referenced this pull request Jan 3, 2025
@santigimeno
deps: update opentelemetry-cpp to 1.17.0
16135f4 
Also, a couple of fixes in the updater:
- Fix OPENTELEMETRY_VERSION extraction.
- Use `third_party_release` file to get the `opentelemetry-proto`.

PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno added a commit that referenced this pull request Jan 3, 2025
@santigimeno
deps: add support for exporting Summary via OTLP
a50340b 
PR-URL: #180
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno added a commit that referenced this pull request Jan 3, 2025
@santigimeno
test: get opentelemetry version from process
7deace9 
PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno added a commit that referenced this pull request Jan 9, 2025
@santigimeno
deps: update opentelemetry-cpp to 1.17.0
4ce8718 
Also, a couple of fixes in the updater:
- Fix OPENTELEMETRY_VERSION extraction.
- Use `third_party_release` file to get the `opentelemetry-proto`.

PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno added a commit that referenced this pull request Jan 9, 2025
@santigimeno
deps: add support for exporting Summary via OTLP
c3f5ecb 
PR-URL: #180
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno added a commit that referenced this pull request Jan 9, 2025
@santigimeno
test: get opentelemetry version from process
e86064c 
PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno added a commit that referenced this pull request Jan 13, 2025
@santigimeno
deps: update opentelemetry-cpp to 1.17.0
4ec5ae8 
Also, a couple of fixes in the updater:
- Fix OPENTELEMETRY_VERSION extraction.
- Use `third_party_release` file to get the `opentelemetry-proto`.

PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #245
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno added a commit that referenced this pull request Jan 13, 2025
@santigimeno
deps: add support for exporting Summary via OTLP
b40869a 
PR-URL: #180
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #245
santigimeno added a commit that referenced this pull request Jan 13, 2025
@santigimeno
test: get opentelemetry version from process
67d4f32 
PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #245
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno added a commit that referenced this pull request Jan 13, 2025
@santigimeno
deps: update opentelemetry-cpp to 1.17.0
14027b4 
Also, a couple of fixes in the updater:
- Fix OPENTELEMETRY_VERSION extraction.
- Use `third_party_release` file to get the `opentelemetry-proto`.

PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #246
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno added a commit that referenced this pull request Jan 13, 2025
@santigimeno
deps: add support for exporting Summary via OTLP
ec13729 
PR-URL: #180
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #246
santigimeno added a commit that referenced this pull request Jan 13, 2025
@santigimeno
test: get opentelemetry version from process
a1ebfb0 
PR-URL: #221
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #246
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@trevnorris trevnorris Awaiting requested review from trevnorris

Assignees

@santigimeno santigimeno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santigimeno @juanarbol