agents: add metrics transform API to agent #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
approved these changes
Apr 24, 2024
7df5555 to
f08389e
Compare
santigimeno
approved these changes
May 29, 2024
Comment on lines
+563
to
+554
| if (Inst().get() == this) { | ||
| ASSERT_EQ(0, OnConfigurationHook(config_agent_cb, weak_from_this())); | ||
| } |
There was a problem hiding this comment.
This is because of the test right? Why aren't you adding the ThreadAdded/RemovedHook methods inside that conditional as well?
There was a problem hiding this comment.
Mostly because I am being lazy. There are two main assumptions:
- A
StatsDAgentinstance will be used for the entire process lifetime - At most 2
StatsDAgentinstances will ever be created.
Using these assumptions, I decided it would be easier for each StatsDAgent instance to set up its own hooks to check when a new thread is created/destroyed rather than have a single global hook that would iterate through a list of StatsDAgent instances when a thread is created/destroyed. This simplified the logic a lot and will be easy to fix if we ever add the ability to remove a hook.
Though, now that I type this up I realize that all the stuff I added for the agent_list_ can be removed. Since it was never used. Will make that change.
Add API to allow retrieving all currently available SharedEnvInst instances. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
The user shouldn't have access to start/stop. No need to expose them. Also remove stop() completely. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Allow users to register a callback that will transform the metrics into a std::string that will be written to the endpoint. In order to do this some of the internals needed to be rewritten so that config() could be called from any thread. The internal usage of config() has been renamed since it will always be called from the StatsDAgent thread. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
f08389e to
9b03aaa
Compare
santigimeno
pushed a commit
that referenced
this pull request
Jun 17, 2024
Add API to allow retrieving all currently available SharedEnvInst instances. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
santigimeno
pushed a commit
that referenced
this pull request
Jun 17, 2024
The user shouldn't have access to start/stop. No need to expose them. Also remove stop() completely. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
santigimeno
pushed a commit
that referenced
this pull request
Jun 17, 2024
Allow users to register a callback that will transform the metrics into a std::string that will be written to the endpoint. In order to do this some of the internals needed to be rewritten so that config() could be called from any thread. The internal usage of config() has been renamed since it will always be called from the StatsDAgent thread. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
santigimeno
pushed a commit
that referenced
this pull request
Jun 20, 2024
Add API to allow retrieving all currently available SharedEnvInst instances. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
santigimeno
pushed a commit
that referenced
this pull request
Jun 20, 2024
The user shouldn't have access to start/stop. No need to expose them. Also remove stop() completely. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
santigimeno
pushed a commit
that referenced
this pull request
Jun 20, 2024
Allow users to register a callback that will transform the metrics into a std::string that will be written to the endpoint. In order to do this some of the internals needed to be rewritten so that config() could be called from any thread. The internal usage of config() has been renamed since it will always be called from the StatsDAgent thread. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to register a callback that will transform the metrics into a std::string that will be written to the endpoint.
Still working on tests.