test: fix flaky test-zmq-basic agent test #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevnorris
reviewed
Apr 9, 2024
trevnorris
approved these changes
Apr 9, 2024
santigimeno
added a commit
that referenced
this pull request
Apr 9, 2024
Make sure the Promise in the test won't resolve until both conditions are met: receive the `agent-exit` msg and the `exit` event of the child process. PR-URL: #117 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
8b034d1 to
c596344
Compare
Make sure the Promise in the test won't resolve until both conditions are met: receive the `agent-exit` msg and the `exit` event of the child process. PR-URL: #117 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
c596344 to
ba70980
Compare
trevnorris
pushed a commit
that referenced
this pull request
Apr 10, 2024
Make sure the Promise in the test won't resolve until both conditions are met: receive the `agent-exit` msg and the `exit` event of the child process. PR-URL: #117 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
trevnorris
pushed a commit
that referenced
this pull request
Apr 11, 2024
Make sure the Promise in the test won't resolve until both conditions are met: receive the `agent-exit` msg and the `exit` event of the child process. PR-URL: #117 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.