agents: use nsuv weak_ptr API's in StatsDAgent #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56a4788 to
58e1add
Compare
trevnorris
approved these changes
Mar 5, 2024
santigimeno
added a commit
that referenced
this pull request
Mar 6, 2024
Which adds support for std::weak_ptr. PR-URL: #100 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Mar 6, 2024
PR-URL: #100 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Mar 6, 2024
Make use of `OneByteString` when possible. PR-URL: #100 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
58e1add to
e152049
Compare
e152049 to
c8fdade
Compare
trevnorris
pushed a commit
that referenced
this pull request
Mar 19, 2024
Which adds support for std::weak_ptr. PR-URL: #100 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
trevnorris
pushed a commit
that referenced
this pull request
Mar 19, 2024
PR-URL: #100 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
trevnorris
pushed a commit
that referenced
this pull request
Mar 19, 2024
Make use of `OneByteString` when possible. PR-URL: #100 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade nsuv to latest.
Also added improvements on strings handling in StatsDAgent binding so we use
OneByteStringwhen possible.