chore: Propose a refactor to use Js instead #4
Conversation
src/lib/ec2Handler.js
Outdated
| // Wait for 5 seconds and send the request again to retrieve the status of the instances | ||
| await sleep(5000); | ||
| response = await client.send(command); | ||
| consoleTable(response.StartingInstances) |
There was a problem hiding this comment.
I'm using console.table because I'm so lazy If we use core.info we need to create the table itself, Just if we want to use an ASCII table to list the instance status.
There was a problem hiding this comment.
There's actually a way of doing that without reimplementing the wheel using the node:console API. But, I got you, that's fine for now.
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
|
@riosje is it ready to go? |
@RafaelGSS do we want to improve the log output to not use |
We can do a follow up PR if needed |
This PR is to propose migrate this composite action to a Javascript, it will give a bit more flexibility.
This implementation contains the following:
gitRunnerHandler.js