Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unhandled promise rejection warnings in tests #68

Closed
lance opened this issue Jun 6, 2017 · 0 comments
Closed

Fix unhandled promise rejection warnings in tests #68

lance opened this issue Jun 6, 2017 · 0 comments
Assignees
@helio-frota
Labels
bug easy-fix

Comments

@lance
Copy link
Member

lance commented Jun 6, 2017

When running the tests some warnings are generated. There are quite a few. Here's an example.

 CircuitBreaker fallback as a rejected promise

    ✔ should be equal
(node:93470) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 8): Error: nope
helio-frota added a commit that referenced this issue Jun 7, 2017
@helio-frota
Fix unhandled promise rejection warnings
338249e 
Connects to #68
@helio-frota helio-frota mentioned this issue Jun 7, 2017
Merged
@ghost ghost added in progress and removed ready labels Jun 7, 2017
@lance lance assigned lance and unassigned helio-frota Jun 7, 2017
helio-frota added a commit that referenced this issue Jun 8, 2017
@helio-frota
Fix unhandled promise rejection warnings (#70)
fd0fee2 
Connects to #68
@lance lance assigned helio-frota and unassigned lance Jun 12, 2017
@snyk-bot snyk-bot mentioned this issue Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helio-frota helio-frota

Labels
bug easy-fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lance @helio-frota