Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redefine error on some other version build environment. #972

Merged
merged 1 commit into from
Jan 24, 2016

Conversation

vowstar
Copy link
Member

@vowstar vowstar commented Jan 24, 2016

This macro will cause EFAULT redefine error while compile in espressif's Lubuntu build environment and ai-thinker's build environment. So add #ifndef EFAULT to check it is more safe.

…u environment)

Signed-off-by: Huang Rui <vowstar@gmail.com>
devsaurus added a commit that referenced this pull request Jan 24, 2016
Fix redefine error on some other version build environment.
@devsaurus devsaurus merged commit 995f77d into nodemcu:dev Jan 24, 2016
@jmattsson
Copy link
Member

Note that this header is part of LWIP, so this fix is likely to go missing at the time of the next SDK+LWIP upgrade.

@vowstar
Copy link
Member Author

vowstar commented Jan 27, 2016

I have another (not good) idea, check the environment in Makefile and define in CCFLAGS while using espressif's Lubuntu. The espressif's lubuntu environment defined COMPILE=gcc and windows XP environment defined lx106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants