Improve coverage of lib/random.js

nodejs · Dec 20, 2019 · 08f4feb · 08f4feb
1 parent b1ef533
commit 08f4feb
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/random.js b/lib/random.js
@@ -16,6 +16,9 @@ function isIntegerTypedArray(o) {
 
 // Spec: https://www.w3.org/TR/WebCryptoAPI/#dfn-Crypto-method-getRandomValues
 module.exports.getRandomValues = (array) => {
+  if (!ArrayBuffer.isView(array))
+    throw new TypeError();
+
   if (!isIntegerTypedArray(array))
     throw new TypeMismatchError();
 

diff --git a/test/unit/random.js b/test/unit/random.js
@@ -25,4 +25,23 @@ describe('crypto.getRandomBytes', () => {
     const buf2 = getRandomValues(Buffer.alloc(1024));
     assert(!buf1.equals(buf2));
   });
+
+  it('should throw if the input is invalid', () => {
+    for (const notAnArrayBufferView of [undefined, null, 5, 'foo']) {
+      assert.throws(() => {
+        getRandomValues(notAnArrayBufferView);
+      }, /TypeError/);
+    }
+
+    const buf = new ArrayBuffer(65544);
+    for (const View of [Float32Array, Float64Array]) {
+      assert.throws(() => {
+        getRandomValues(new View(buf));
+      }, /TypeMismatchError/);
+    }
+
+    assert.throws(() => {
+      getRandomValues(new Uint32Array(buf));
+    }, /QuotaExceededError/);
+  });
 });