Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win: add S_ISFIFO macro #207

Merged
merged 1 commit into from
May 19, 2023
Merged

win: add S_ISFIFO macro #207

merged 1 commit into from
May 19, 2023

Conversation

santigimeno
Copy link
Member

Needed now that libuv is setting the mode correctly for named pipes.

Refs: libuv/libuv#3811

Needed now that `libuv` is setting the mode correctly for named pipes.

Refs: libuv/libuv#3811
Copy link
Collaborator

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI passes. Thanks Santi!

@cjihrig cjihrig merged commit 4058102 into nodejs:main May 19, 2023
@cjihrig
Copy link
Collaborator

cjihrig commented May 19, 2023

Released as v0.0.18. The Node.js update PR is at nodejs/node#47866

mhdawson pushed a commit that referenced this pull request Jul 28, 2023
Needed now that `libuv` is setting the mode correctly for named pipes.

Refs: libuv/libuv#3811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants