Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use parser.execute #571

Closed
wants to merge 8 commits into from
Closed

use parser.execute #571

wants to merge 8 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Feb 26, 2021

No description provided.

@ronag
Copy link
Member Author

ronag commented Feb 26, 2021

@dnlup I think this will help with the wasm stuff you are working on. Removes usage of kOnExecute in favor of parser.execute.

@ronag
Copy link
Member Author

ronag commented Feb 27, 2021

#22

mcollina
mcollina reviewed Feb 27, 2021
View reviewed changes
lib/client-request.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag force-pushed the parser-execute branch 2 times, most recently from b387959 to d276644 Compare February 27, 2021 00:45
@codecov-io
Copy link

codecov-io commented Feb 27, 2021 •
edited
Loading

Codecov Report

Merging #571 (6920db3) into master (3d002c1) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   99.36%   98.93%   -0.44%     
==========================================
  Files          16       16              
  Lines        1414     1405       -9     
==========================================
- Hits         1405     1390      -15     
- Misses          9       15       +6
Impacted Files Coverage Δ
lib/core/client.js 99.12% <100.00%> (-0.02%) ⬇️
lib/core/util.js 88.15% <0.00%> (-7.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d002c1...6920db3. Read the comment docs.

@dnlup
Copy link
Contributor

dnlup commented Feb 27, 2021

@dnlup I think this will help with the wasm stuff you are working on. Removes usage of kOnExecute in favor of parser.execute.

Yes, definitely ❤️

@dnlup dnlup mentioned this pull request Feb 28, 2021
Closed
7 tasks
@ronag
Copy link
Member Author

ronag commented Feb 28, 2021

Has been rebased into #575

@ronag ronag closed this Feb 28, 2021
@ronag ronag deleted the parser-execute branch April 25, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronag @codecov-io @dnlup @mcollina