fix: handle missing vary header values #4031
Merged
+166
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurgunday
commented
Jan 27, 2025
mcollina
reviewed
Jan 28, 2025
metcoder95
approved these changes
Jan 28, 2025
|
@KhafraDev can you take a look as well? This issue recently bit me too |
|
Cc @flakey5, just saw your PR but leaving it here if you want to merge this one It fixes both the undercase problem and the cache issue |
metcoder95
approved these changes
Feb 2, 2025
flakey5
suggested changes
Feb 2, 2025
test/utils/cache.js
Outdated
| const assert = require('node:assert') | ||
| const { parseVaryHeader } = require('../../lib/util/cache.js') | ||
|
|
||
| describe('parseVaryHeader', () => { |
There was a problem hiding this comment.
nit but could you move these to where the other tests are for this function?
undici/test/cache-interceptor/utils.js
Line 179 in a9176c9
|
Yeah had to go back to null, it works better with JSON 😁 |
flakey5
approved these changes
Feb 2, 2025
metcoder95
approved these changes
Feb 7, 2025
Co-authored-by: flakey5 <73616808+flakey5@users.noreply.github.com>
|
Rebased |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3959